On 4/7/2014 11:11 AM, Nicholas A. Bellinger wrote:
Looks good to me. Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> This is useless though without the code setting this prot_op in sbc_set_prot_op_checks()...Not sure I follow.. sbc_set_prot_op_checks() is already setting TARGET_PROT_DOUT_INSERT when no protect field in the WRITE CDB has been set, eg: static int sbc_set_prot_op_checks(u8 protect, enum target_prot_type prot_type, bool is_write, struct se_cmd *cmd) { if (is_write) { cmd->prot_op = protect ? TARGET_PROT_DOUT_PASS : TARGET_PROT_DOUT_INSERT; <SNIP> } } Which in-turn is what causes this code to invoke sbc_dif_write_insert (now sbc_dif_generate) when the backend supports PI, and the fabric itself does not support WRITE_INSERT hw offload.
pphh, I confused this with DOUT_STRIP/DIN_INSERT. You can discard. Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
