On 4/1/2014 4:11 AM, Nicholas A. Bellinger wrote:
<SNIP>
+
+ if (scsi_host_get_prot(lport->qla_vha->host)) {
+ tpg->se_tpg.fabric_sup_prot_type = (TARGET_DIF_TYPE0_PROT|
+ TARGET_DIF_TYPE1_PROT|TARGET_DIF_TYPE2_PROT|
+ TARGET_DIF_TYPE3_PROT);
+
+ tpg->se_tpg.fabric_sup_guard_type = TARGET_GUARD_CRC|
+ TARGET_GUARD_IP;
+ }
ret = core_tpg_register(&tcm_qla2xxx_fabric_configfs->tf_ops, wwn,
&tpg->se_tpg, tpg, TRANSPORT_TPG_TYPE_NORMAL);
@@ -1127,6 +1147,8 @@ static ssize_t tcm_qla2xxx_npiv_tpg_store_enable(
qlt_stop_phase1(vha->vha_tgt.qla_tgt);
}
+ core_tpg_set_fabric_t10dif(se_tpg, tpg->tpg_attrib.t10dif_force_on);
+
Any way we can get this logic to be shared also with iscsi, srp, etc...
all fabrics should
be set with t10dif right? so I would imagine it would be better to
centralize it right?
QT> Not sure how you want this logic to be shared. This patch is specific
to Qlogic driver registering its capabilities.
I think that Sagi was referring to a target_core_fabric_ops callback to
query protection information from the fabric..
As mentioned in the last response, this would work just fine on
a /sys/kernel/config/target/$FABRIC/$WWPN/$TPGT context basis, if it
wasn't for iscsi-target / iser-target sharing the same endpoint while
still allowing different protection modes.
So no way to get it centralized? I still don't understand the iscsi/iser
constraint.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
