On Mon, Mar 31, 2014 at 12:58:01AM -0500, Mike Christie wrote:
>
> Hey,
>
> I just wanted to double check that the only time we do bidi requests is
> when they come through as REQ_TYPE_BLOCK_PC requests. I saw some of the
> code comments on the init side that indicated that, but there was that
> scsi_end_request() -> scsi_release_buffers() -> __scsi_release_buffers()
> call which then did not make sense because we were passing in 1 for the
> bidi check argument.
We only support BIDI for REQ_TYPE_BLOCK_PC requests, and scsi_io_completion
enforces this:
if (req->cmd_type == REQ_TYPE_BLOCK_PC) { /* SG_IO ioctl from block level */
...
if (scsi_bidi_cmnd(cmd)) {
...
< end_io and return >
}
}
/* no bidi support for !REQ_TYPE_BLOCK_PC yet */
BUG_ON(blk_bidi_rq(req));
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
