re: [SCSI] be2iscsi: Fix handling timed out MBX completion from FW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jayamohan Kallickal,

The patch 1957aa7f6246: "[SCSI] be2iscsi: Fix handling timed out MBX
completion from FW" from Jan 29, 2014, leads to the following static
checker warning:

	drivers/scsi/be2iscsi/be_main.c:5581 beiscsi_dev_probe()
	error: memset() '&phba->ctrl.ptag_state[i]->tag_mem_state' too small (24 vs 32)

drivers/scsi/be2iscsi/be_main.c
  5576          for (i = 0; i < MAX_MCC_CMD; i++) {
  5577                  init_waitqueue_head(&phba->ctrl.mcc_wait[i + 1]);
  5578                  phba->ctrl.mcc_tag[i] = i + 1;
  5579                  phba->ctrl.mcc_numtag[i + 1] = 0;
  5580                  phba->ctrl.mcc_tag_available++;
  5581                  memset(&phba->ctrl.ptag_state[i].tag_mem_state, 0,
  5582                         sizeof(struct beiscsi_mcc_tag_state));
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Probably this this be change to sizeof(struct be_dma_mem struct)?  It
looks like we are corrupting memory a bit here.

  5583          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux