On Tue, Mar 25, 2014 at 06:13:06AM -0700, Christoph Hellwig wrote: > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > index 78b004d..4021849 100644 > > --- a/drivers/scsi/scsi_error.c > > +++ b/drivers/scsi/scsi_error.c > > @@ -2289,6 +2289,9 @@ scsi_reset_provider(struct scsi_device *dev, int flag) > > return FAILED; > > > > scmd = scsi_get_command(dev, GFP_KERNEL); > > + if (!scmd) > > + return FAILED; > > + > > Fails to call scsi_autopm_put_host, or in Jame's latest tree that has > my changes put_device on the sdev gendev. I sent a correct version > earlier, but there has been very little enthusiasm for it. > Yes you are right, it should call scsi_autopm_put_host before returning. So if you already have a correct version for it then I drop this patch. Maurizio. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html