On 03/17/2014 02:25 AM, Or Gerlitz wrote: > On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg <sagig@xxxxxxxxxxxx> wrote: >> > >> > iSCSI needs to be at least aware that a task involves protection >> > information. In case it does, after the transaction completed >> > libiscsi will ask the transport to check the protection status >> > of the transaction. >> > >> > Unlike transport errors, DIF errors should not prevent successful >> > completion of the transaction from the transport point of view, >> > but should be escelated to scsi mid-layer when constructing the >> > scsi result and sense data. >> > >> > check_protection routine will return the ascq corresponding to the >> > DIF error that occured (or 0 if no error happened). >> > >> > return ascq: >> > - 0x1: GUARD_CHECK_FAILED >> > - 0x2: APPTAG_CHECK_FAILED >> > - 0x3: REFTAG_CHECK_FAILED > Hi Mike, just to remove doubt, this patch is OK with you, right? can > you please ack it, so we know we're all good for the 3.15 merge window > This patch is ok, but happened to the patch for the xmit task path? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html