On 03/02/2014 09:53 AM, Bart Van Assche wrote: > On 02/13/14 11:27, Hannes Reinecke wrote: >> After discussion with jejb I've dropped the EVPD parsing. >> So with this version we're just displaying the EVPD page >> 0x80 and 0x83 as hexdumps; no parsing is attempted. >> This drastically simplifies the patch, and we don't >> have to worry about any parsing errors in kernel space. >> Of course we'll need a parser in userspace, but that >> doesn't need to do any I/O. So it's still a very nice >> gain. > > A general comment about this patch series: I think the cached copies of > these pages should be refreshed at least after an INQUIRY DATA HAS > CHANGED unit attention code has been received. Some SCSI target > implementations allow to change this data after a LUN has been created. > Yes, eventually. But this needs to be handled in a general context, as (potentially) even the inquiry string itself has been invalidated after receiving such an event. So we should be doing a rescan of the scsi device upon receiving such an event. But this is a general problem, not one particular to this patchset. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
