On Saturday 01 March 2014, Michael Schmitz wrote: > > sleep_on is known broken and going away. The atari_scsi driver is one of > two remaining users in the falcon_get_lock() function, which is a rather > crazy piece of code. This does not attempt to fix the driver's locking > scheme in general, but at least prevents falcon_get_lock from going to > sleep when no other thread holds the same lock or tries to get it, > and we no longer schedule with irqs disabled. > > MSch: fixed completion conditions missed in Arnds' original RFC patch. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Acked-by: Michael Schmitz <schmitz@xxxxxxxxxx> > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Cc: James E.J. Bottomley <JBottomley@xxxxxxxxxxxxx> > Cc: linux-scsi@xxxxxxxxxxxxxxx Thanks a lot for taking care of this so quickly! A minor note about patch processing: The normal way to forward a patch from another person is to add your 'Signed-off-by:' line below the one from the original submitter, i.e. in the place where you have the 'Acked-by:'. Not sure if you just forgot to update your patch or you weren't aware of that. Geert will be able to fix that when he adds his own Signed-off-by line. Also if you want to preserve authorship of the patch, you can add as the first line before the description a line 'From: Arnd Bergmann <arnd@xxxxxxxx>'. Since you modified most the lines I originally changed and the patch is very small, I don't care about having me listed as the author, it's absolutely ok to have you listed here, just explaining it here in case you intended differently. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html