On 01/31/14 10:29, Hannes Reinecke wrote: > + if (!target_id_size) { > + /* Check for EMC Clariion extended inquiry */ > + if (!strncmp(sdev->vendor, "DGC ", 8) && > + sdev->inquiry_len > 160) { > + target_id_size = sdev->inquiry[160]; > + target_id = sdev->inquiry + 161; > + strcpy(target_id_str, "emc."); > + memcpy(target_id_str + 4, target_id, target_id_size); > + } > + /* Check for HP EVA extended inquiry */ > + if (!strncmp(sdev->vendor, "HP ", 8) && > + !strncmp(sdev->model, "HSV", 3) && > + sdev->inquiry_len > 170) { > + target_id_size = 16; > + target_id = sdev->inquiry + 154; > + strcpy(target_id_str, "naa."); > + memcpy(target_id_str + 4, target_id, target_id_size); > + } > + } Being able to identify a storage array unambiguously is essential for the new ALUA device handler algorithm introduced by this patch series. What if a new storage array is introduced that is not covered by one of the heuristics in this patch ? Has it been considered to let storage array identification occur in user space instead of in the kernel ? Thanks, Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html