Hi all, here's now the (hopefully) final version of my patch to display EVPD pages in sysfs. After some discussion with Kay Sievers I've found that the whole thing can be made far simpler by using the 'is_visible' callback to the sysfs attribute group. And we can even simplify existing code here. The patch itself has been modified to add boundary checks to handle invalid pages gracefully. Hannes Reinecke (2): scsi_sysfs: Implement 'is_visible' callback Add EVPD page 0x83 entries to sysfs drivers/scsi/scsi_scan.c | 3 + drivers/scsi/scsi_sysfs.c | 518 +++++++++++++++++++++++++++++++++++++-------- include/scsi/scsi.h | 4 +- include/scsi/scsi_device.h | 3 + 4 files changed, 433 insertions(+), 95 deletions(-) -- 1.7.12.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html