Re: [PATCH] scsi/isci/port_config: Fix a infinite loop.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 16, 2013 at 7:54 PM, Xinghai Yu <yuxinghai@xxxxxxxxxxxxxx> wrote:
> It seems the "phy_index++;" have been placed in wrong place, without it
> the while circle up will do a infinite loop.
>
> Signed-off-by: Xinghai Yu <yuxinghai@xxxxxxxxxxxxxx>
> ---
>  drivers/scsi/isci/port_config.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c
> index cd962da..85c77f6 100644
> --- a/drivers/scsi/isci/port_config.c
> +++ b/drivers/scsi/isci/port_config.c
> @@ -311,9 +311,9 @@ sci_mpc_agent_validate_phy_configuration(struct isci_host *ihost,
>                                               &ihost->phys[phy_index]);
>
>                         assigned_phy_mask |= (1 << phy_index);
> +                       phy_index++;
>                 }
>
> -               phy_index++;
>         }
>
>         return sci_port_configuration_agent_validate_ports(ihost, port_agent);

Hmm, I'm not aware of anyone using mpc mode.  Maybe we should just remove it?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux