On Wed, 2014-01-22 at 18:44 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ > > exception cases into transport_send_check_condition_and_sense(). > > > > This includes: > > > > LOGICAL BLOCK GUARD CHECK FAILED > > LOGICAL BLOCK APPLICATION TAG CHECK FAILED > > LOGICAL BLOCK REFERENCE TAG CHECK FAILED > > > > that used by DIF TYPE1 and TYPE3 failure cases. > > > > Cc: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > > Cc: Christoph Hellwig <hch@xxxxxx> > > Cc: Hannes Reinecke <hare@xxxxxxx> > > Cc: Sagi Grimberg <sagig@xxxxxxxxxxxx> > > Cc: Or Gerlitz <ogerlitz@xxxxxxxxxxxx> > > Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > --- > > drivers/target/target_core_transport.c | 30 ++++++++++++++++++++++++++++++ > > include/target/target_core_base.h | 3 +++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c > > index 18c828d..fa4fc04 100644 > > --- a/drivers/target/target_core_transport.c > > +++ b/drivers/target/target_core_transport.c > > @@ -2674,6 +2674,36 @@ transport_send_check_condition_and_sense(struct se_cmd *cmd, > > buffer[SPC_ASC_KEY_OFFSET] = 0x1d; > > buffer[SPC_ASCQ_KEY_OFFSET] = 0x00; > > break; > > + case TCM_LOGICAL_BLOCK_GUARD_CHECK_FAILED: > > + /* CURRENT ERROR */ > > + buffer[0] = 0x70; > > + buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10; > > + /* ILLEGAL REQUEST */ > > + buffer[SPC_SENSE_KEY_OFFSET] = ILLEGAL_REQUEST; > > + /* LOGICAL BLOCK GUARD CHECK FAILED */ > > + buffer[SPC_ASC_KEY_OFFSET] = 0x10; > > + buffer[SPC_ASCQ_KEY_OFFSET] = 0x01; > > + break; > > + case TCM_LOGICAL_BLOCK_APP_TAG_CHECK_FAILED: > > + /* CURRENT ERROR */ > > + buffer[0] = 0x70; > > + buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10; > > + /* ILLEGAL REQUEST */ > > + buffer[SPC_SENSE_KEY_OFFSET] = ILLEGAL_REQUEST; > > + /* LOGICAL BLOCK APPLICATION TAG CHECK FAILED */ > > + buffer[SPC_ASC_KEY_OFFSET] = 0x10; > > + buffer[SPC_ASCQ_KEY_OFFSET] = 0x02; > > + break; > > + case TCM_LOGICAL_BLOCK_REF_TAG_CHECK_FAILED: > > + /* CURRENT ERROR */ > > + buffer[0] = 0x70; > > + buffer[SPC_ADD_SENSE_LEN_OFFSET] = 10; > > + /* ILLEGAL REQUEST */ > > + buffer[SPC_SENSE_KEY_OFFSET] = ILLEGAL_REQUEST; > > + /* LOGICAL BLOCK REFERENCE TAG CHECK FAILED */ > > + buffer[SPC_ASC_KEY_OFFSET] = 0x10; > > + buffer[SPC_ASCQ_KEY_OFFSET] = 0x03; > > + break; > > Hey Nic, > > I think we missed the failed LBA here. AFAICT According to SPC-4, a DIF > error should be accompanied by Information sense-data descriptor with > the (first) failed > sector in the information field. This means that this routine should be > ready to accept a > u32 bad_sector or something. I'm not sure how much of a must it really is. > > Let me prepare a patch... > Ah yes, good catch. This is what se_cmd->block_num was intended for.. Care to add these assignments to target_core_sbc.c:sbc_dif_verify_* failures as well..? --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
