On Fri, 17 Jan 2014, Tejun Heo wrote: > Hello, > > On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote: > > The START-STOP may result in an error. What do you do in that case? > > At least for libata, worrying about suspend/resume failures don't make > whole lot of sense. If suspend failed, just proceed with suspend. If > the device can't be woken up afterwards, that's that. There isn't > anything we could have done differently anyway. The same for resume, > if spinup fails, the device is dud and the following commands will > invoke EH actions and will eventually fail. Again, there really isn't > any *choice* to make. Just making sure the errors are handled > gracefully (ie. don't crash) and the following commands are handled > correctly should be enough. Absolutely. Even with normal synchronous resumes, we don't do anything if an error occurs, other than printing it in the kernel log. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
