Re: [PATCH 4/7] be2iscsi : Fix statistics update in the driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/12/2014 06:42 PM, Jayamohan Kallickal wrote:
>  
> diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
> index 0076119..d21ad9e 100644
> --- a/drivers/scsi/be2iscsi/be_main.h
> +++ b/drivers/scsi/be2iscsi/be_main.h
> @@ -449,6 +449,25 @@ struct beiscsi_conn {
>  	struct sgl_handle *plogin_sgl_handle;
>  	struct beiscsi_session *beiscsi_sess;
>  	struct iscsi_task *task;
> +
> +	/* CXN statistics */
> +	/* Xmit Counters */
> +	uint32_t noptx_pdus;
> +	uint32_t login_pdus;
> +	uint32_t text_pdus;
> +	uint32_t logout_pdus;
> +	uint32_t snack_pdus;
> +
> +	/* Rx Counters */
> +	uint32_t noprx_pdus;
> +	uint32_t textrsp_pdus;
> +	uint32_t logoutrsp_pdus;
> +	uint32_t async_pdus;
> +	uint32_t rjt_pdus;
> +
> +	/* Error Counters */
> +	uint32_t digest_err;
> +	uint32_t format_err;
>  };
>  

You should put these on the iscsi_conn struct then have
__iscsi_complete_pdu handle the counters.

libiscsi should then also setup processing of those stats. You should
make a libiscsi helper which the drivers call. See iscsi_tcp
iscsi_sw_tcp_conn_get_stats call to iscsi_tcp_conn_get_stats for an
example for how it is done with libiscsi_tcp and lower level stats it
manages.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux