Hi,
>> + sata23clk: sata23clk@1f22c000 {
>> + compatible = "apm,xgene-device-clock";
>> + #clock-cells = <1>;
>> + clocks = <&socplldiv2 0>;
>> + clock-names = "sata23clk";
>
>> + };
>> +
>> + sata45clk: sata45clk@1f23c000 {
>> + compatible = "apm,xgene-device-clock";
>> + #clock-cells = <1>;
>> + clocks = <&socplldiv2 0>;
>> + clock-names = "sata45clk";
>
> Something is wrong here: You have two devices with the same "compatible"
> string but using different "clock-names" strings. The binding document
> lists this as an optional property with the description "shall be
> the name of the device clock. If missing, use the device name", which
> doesn't seem to make any sense.
>
> Please fix the binding and the existing users of this, and don't introduce
> any more broken instances. Since each device clock is documented to
> have only one parent anyway, please just make it an anonymous clock.
Okay I miss understood this... I will need to fix the X-Gene device
parent clocks as well in an separate patch to the clock driver owner.
-Loc
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
