On Wed, Dec 18, 2013 at 11:54:32PM +0530, Rashika Kheria wrote: > Move prototype declaration of function > spc_parse_naa_6h_vendor_specific() from target_core_xcopy.c to header > file target_core_pr.h because it is used by more than one file. > > This eliminates the following warning in target_core_spc.c: > drivers/target/target_core_spc.c:138:6: warning: no previous prototype for ‘spc_parse_naa_6h_vendor_specific’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > drivers/target/target_core_pr.h | 5 +++++ > drivers/target/target_core_xcopy.c | 4 ---- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/target/target_core_pr.h b/drivers/target/target_core_pr.h > index ed75cdd..2ee2936 100644 > --- a/drivers/target/target_core_pr.h > +++ b/drivers/target/target_core_pr.h > @@ -43,6 +43,11 @@ > #define PR_APTPL_MAX_IPORT_LEN 256 > #define PR_APTPL_MAX_TPORT_LEN 256 > > +/* > + * Function defined in target_core_spc.c > + */ > +void spc_parse_naa_6h_vendor_specific(struct se_device *, unsigned char *); > + > extern struct kmem_cache *t10_pr_reg_cache; > > extern void core_pr_dump_initiator_port(struct t10_pr_registration *, > diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c > index 6b88a99..669c536 100644 > --- a/drivers/target/target_core_xcopy.c > +++ b/drivers/target/target_core_xcopy.c > @@ -40,10 +40,6 @@ > > static struct workqueue_struct *xcopy_wq = NULL; > /* > - * From target_core_spc.c > - */ > -extern void spc_parse_naa_6h_vendor_specific(struct se_device *, unsigned char *); > -/* > * From target_core_device.c > */ > extern struct mutex g_device_mutex; > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
