Re: [PATCH 1/7] lpfc 8.3.44: Fixed IO hang when in msi mode.

[James Smart <james.smart@xxxxxxxxxx>]

yep.  Sorry.  Will resend shortly.

-- james


On 12/17/2013 3:30 PM, James Bottomley wrote:
> On Mon, 2013-12-02 at 12:48 -0500, James Smart wrote:
> > Fixed IO hang when in msi mode.
> >
> >
> > Signed-off-by: James Smart <james.smart@xxxxxxxxxx>
> There seems to be a lot of tab vs space checkpatch warnings in this
> series:
>
> ERROR: code indent should use tabs where possible
> #24: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4792:
> +                                 cmnd->device ? cmnd->device->lun :
> 0xffff,$
>
> WARNING: please, no spaces at the start of a line
> #24: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4792:
> +                                 cmnd->device ? cmnd->device->lun :
> 0xffff,$
>
> ERROR: code indent should use tabs where possible
> #25: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4793:
> +                                 vport->fc_myDID, ndlp->nlp_DID,$
>
> WARNING: please, no spaces at the start of a line
> #25: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4793:
> +                                 vport->fc_myDID, ndlp->nlp_DID,$
>
> ERROR: code indent should use tabs where possible
> #26: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4794:
> +                                 phba->sli_rev == LPFC_SLI_REV4 ?$
>
> WARNING: please, no spaces at the start of a line
> #26: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4794:
> +                                 phba->sli_rev == LPFC_SLI_REV4 ?$
>
> ERROR: code indent should use tabs where possible
> #27: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4795:
> +                                 lpfc_cmd->cur_iocbq.sli4_xritag :
> 0xffff,$
>
> WARNING: please, no spaces at the start of a line
> #27: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4795:
> +                                 lpfc_cmd->cur_iocbq.sli4_xritag :
> 0xffff,$
>
> ERROR: code indent should use tabs where possible
> #28: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4796:
> +                                 lpfc_cmd->cur_iocbq.iocb.ulpContext,$
>
> WARNING: please, no spaces at the start of a line
> #28: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4796:
> +                                 lpfc_cmd->cur_iocbq.iocb.ulpContext,$
>
> ERROR: code indent should use tabs where possible
> #29: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4797:
> +                                 lpfc_cmd->cur_iocbq.iocb.ulpIoTag,$
>
> WARNING: please, no spaces at the start of a line
> #29: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4797:
> +                                 lpfc_cmd->cur_iocbq.iocb.ulpIoTag,$
>
> ERROR: code indent should use tabs where possible
> #30: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4798:
> +                                 lpfc_cmd->cur_iocbq.iocb.ulpTimeout,$
>
> WARNING: please, no spaces at the start of a line
> #30: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4798:
> +                                 lpfc_cmd->cur_iocbq.iocb.ulpTimeout,$
>
> ERROR: code indent should use tabs where possible
> #31: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4799:
> +                                 (uint32_t)$
>
> WARNING: please, no spaces at the start of a line
> #31: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4799:
> +                                 (uint32_t)$
>
> ERROR: code indent should use tabs where possible
> #32: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4800:
> +                                  (cmnd->request->timeout / 1000));$
>
> WARNING: please, no spaces at the start of a line
> #32: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4800:
> +                                  (cmnd->request->timeout / 1000));$
>
> total: 9 errors, 9 warnings, 33 lines checked
>
> NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
> or
>        scripts/cleanfile
>
> I don't think it's your mailer otherwise the patch wouldn't have
> applied.  Could you fix and resend the series?
>
> Thanks,
>
> James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html