On Fri, 2013-12-13 at 15:59 -0800, Andy Grover wrote:
> lun->lun_ref is also initialized in core_tpg_post_addlun, so it doesn't
> need to be done in core_tpg_setup_virtual_lun0.
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
> drivers/target/target_core_tpg.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
> index 8771b23..2f6df57 100644
> --- a/drivers/target/target_core_tpg.c
> +++ b/drivers/target/target_core_tpg.c
> @@ -658,10 +658,6 @@ static int core_tpg_setup_virtual_lun0(struct se_portal_group *se_tpg)
> spin_lock_init(&lun->lun_sep_lock);
> init_completion(&lun->lun_ref_comp);
>
> - ret = percpu_ref_init(&lun->lun_ref, core_tpg_lun_ref_release);
> - if (ret < 0)
> - return ret;
> -
> ret = core_tpg_post_addlun(se_tpg, lun, lun_access, dev);
> if (ret < 0) {
> percpu_ref_cancel_init(&lun->lun_ref);
Applied to target-pending/queue, and will be including in the next -rc5
PULL request.
--nab
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
