On Wednesday 20 November 2013 11:37:05 Mark Rutland wrote: > > +static void phy_rd(void *addr, u32 *val) > > +{ > > + *val = readl(addr); > > +#if defined(XGENE_DBG1_CSR) > > + pr_debug("SATAPHY CSR RD: 0x%p value: 0x%08x\n", addr, *val); > > Can you not use dev_dbg here as you do elsehere? > > Either that or make your own debug print function, with the ifdefs > hidden in its definition. > pr_debug() is already conditional on #ifdef DEBUG, the extra #if can just get removed here. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html