On Fri, 2013-11-15 at 17:53 -0200, Geyslan Gregório Bem wrote:
Hi,
> Hi guys,
>
> In the function msgin_qtag() [line 2632], this dereference was intentional?
>
> static struct ScsiReqBlk *msgin_qtag(struct AdapterCtlBlk *acb,
> struct DeviceCtlBlk *dcb, u8 tag)
> {
> struct ScsiReqBlk *srb = NULL;
> struct ScsiReqBlk *i;
> dprintkdbg(DBG_0, "msgin_qtag: (0x%p) tag=%i srb=%p\n",
> srb->cmd, tag, srb);
> ...
>
> There is a srb (NULL) dereference in the dprintkdbg() parameteres.
That is a bad bug.
> If not, what approach do you suggest me for a patch?
Merge it with
dprintkdbg(DBG_0, "msgin_qtag: (0x%p) <%02i-%i>\n",
srb->cmd, srb->dcb->target_id, srb->dcb->target_lun);
later in the function.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
