RE: [PATCH V2 01/10] pm80xx: Device id changes to support series 8 controllers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We will modify and send updated patch.

-----Original Message-----
From: Jack Wang [mailto:xjtuwjp@xxxxxxxxx] 
Sent: Thursday, September 26, 2013 12:10 PM
To: Anand Kumar Santhanam
Cc: linux-scsi@xxxxxxxxxxxxxxx; Sangeetha Gnanasekaran; Nikith
Ganigarakoppal; Viswas G
Subject: Re: [PATCH V2 01/10] pm80xx: Device id changes to support
series 8 controllers.

snip
>  	 */
>  	payload.ase_sh_lm_slr_phyid = cpu_to_le32(SPINHOLD_DISABLE |
>  			LINKMODE_AUTO | LINKRATE_15 |
> -			LINKRATE_30 | LINKRATE_60 | phy_id);
> +			LINKRATE_30 | LINKRATE_60 | LINKRATE_120 |
phy_id);
Is it safe to set 12g linkrate support also on 6g, if so, then :

Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxxx>

>  	/* SSC Disable and SAS Analog ST configuration */
>  	/**
>  	payload.ase_sh_lm_slr_phyid =
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.h
b/drivers/scsi/pm8001/pm80xx_hwi.h
> index 2b760ba..9a9116d 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.h
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.h
> @@ -168,6 +168,7 @@
>  #define LINKRATE_15			(0x01 << 8)
>  #define LINKRATE_30			(0x02 << 8)
>  #define LINKRATE_60			(0x06 << 8)
> +#define LINKRATE_120			(0x08 << 8)
>  
>  /* Thermal related */
>  #define	THERMAL_ENABLE			0x1
> @@ -1223,10 +1224,10 @@ typedef struct SASProtocolTimerConfig
SASProtocolTimerConfig_t;
>  
>  /* MSGU CONFIGURATION TABLE*/
>  
> -#define SPCv_MSGU_CFG_TABLE_UPDATE		0x01
> -#define SPCv_MSGU_CFG_TABLE_RESET		0x02
> -#define SPCv_MSGU_CFG_TABLE_FREEZE		0x04
> -#define SPCv_MSGU_CFG_TABLE_UNFREEZE		0x08
> +#define SPCv_MSGU_CFG_TABLE_UPDATE		0x001
> +#define SPCv_MSGU_CFG_TABLE_RESET		0x002
> +#define SPCv_MSGU_CFG_TABLE_FREEZE		0x004
> +#define SPCv_MSGU_CFG_TABLE_UNFREEZE		0x008
>  #define MSGU_IBDB_SET				0x00
>  #define MSGU_HOST_INT_STATUS			0x08
>  #define MSGU_HOST_INT_MASK			0x0C
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux