>-----Original Message----- >From: James Bottomley [mailto:jbottomley@xxxxxxxxxxxxx] >Sent: Wednesday, September 11, 2013 3:42 AM >To: Saxena, Sumit >Cc: linux-scsi@xxxxxxxxxxxxxxx; Desai, Kashyap; aradford@xxxxxxxxx >Subject: Re: [PATCH][SCSI] megaraid_sas: addded support for big endian >architecture > >On Fri, 2013-09-06 at 15:50 +0530, Sumit.Saxena@xxxxxxx wrote: >> This patch will add big endian architecture support to megaraid_sas >> driver. The support added is for LSI MegaRAID all generation >controllers- (3Gb/s, 6Gb/s and 12 Gb/s controllers). >> >> This patch will be applied on top of recently submitted patch for High >> Avaibility support- >> http://marc.info/?l=linux-scsi&m=137799326426659&w=2 >> We have done basic sanity test @ppc64 arch and @x86_64. Additional >testing/observations are welcome. > >Well, no it won't actually; it gives a rejection here: > > >> --- drivers/scsi/megaraid/megaraid_sas_base.c >> +++ drivers/scsi/megaraid/megaraid_sas_base.c >> @@ -5097,8 +5142,9 @@ >> >> for (i = 0; i < ioc->sge_count && kbuff_arr[i]; i++) { >> dma_free_coherent(&instance->pdev->dev, >> - kern_sge32[i].length, >> - kbuff_arr[i], kern_sge32[i].phys_addr); >> + le32_to_cpu(kern_sge32[i].length), >> + kbuff_arr[i], >> + le32_to_cpu(kern_sge32[i].phys_addr)); >> } >> >> megasas_return_cmd(instance, cmd); > >Because you didn't take into account this patch: > >Author: Bjørn Mork <bjorn@xxxxxxx> >Date: Wed Nov 21 09:54:48 2012 +0100 > > [SCSI] megaraid_sas: fix memory leak if SGL has zero length entries > >I fixed it up this time, but could you please work against the misc >branch of the scsi git repo to prevent this type of problem in future? Sorry for inconvenience. In future, I will take care of this. > >Thanks, > >James > Thanks, Sumit -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
