> +struct esas2r_adapter {
> + struct esas2r_target targetdb[ESAS2R_MAX_TARGETS];
> + struct esas2r_target *targetdb_end;
...
> + u8 fw_coredump_buff[ESAS2R_FWCOREDUMP_SZ];
> +void esas2r_reset_chip(struct esas2r_adapter *a)
> +{
> + if (!esas2r_is_adapter_present(a))
> + return;
> +
> + /*
> + * Before we reset the chip, save off the VDA core dump. The VDA core
> + * dump is located in the upper 512KB of the onchip SRAM. Make sure
> + * to not overwrite a previous crash that was saved.
> + */
> + if ((a->flags2 & AF2_COREDUMP_AVAIL)
> + && !(a->flags2 & AF2_COREDUMP_SAVED)
> + && a->fw_coredump_buff) {
> + esas2r_read_mem_block(a,
> + a->fw_coredump_buff,
> + MW_DATA_ADDR_SRAM + 0x80000,
> + ESAS2R_FWCOREDUMP_SZ);
Comparing an array (fw_coredump_buff) to null probably isn't what you intended here.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
