On Mon, Sep 02, 2013 at 08:59:30PM +0200, Bart Van Assche wrote: > Do you agree with changing switch (state) into switch ((int)state) ? > Without that additional change gcc reports the following warning: > > drivers/scsi/scsi_sysfs.c: In function ?store_state_field?: > drivers/scsi/scsi_sysfs.c:640:2: warning: case value ?0? not in > enumerated type ?enum scsi_device_state? [-Wswitch] Either that, or add a SDEV_INVALID_STATE = 0 value to the enum. That variant seems a little more elegant. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html