On Wed, Aug 28, 2013 at 8:30 PM, Akinobu Mita <mita@xxxxxxxxxxxx> wrote:
> When the query request with read descriptor opcode is completed, the
> descriptor is copied from response UPIU to the buffer that the caller
> has specified. Unfortunately the source address of the descriptor is
> broken due to the unnecessary address-of operator.
>
> Signed-off-by: Akinobu Mita <mita@xxxxxxxxxxxx>
> Cc: Dolev Raviv <draviv@xxxxxxxxxxxxxx>
> Cc: Sujit Reddy Thumma <sthumma@xxxxxxxxxxxxxx>
> Cc: Vinayak Holikatti <vinholikatti@xxxxxxxxx>
> Cc: Santosh Y <santoshsy@xxxxxxxxx>
> Cc: James Bottomley <JBottomley@xxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> ---
> drivers/scsi/ufs/ufshcd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index a0f5ac2..7a319c6 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -454,8 +454,7 @@ void ufshcd_copy_query_response(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
>
> /* Get the descriptor */
> if (lrbp->ucd_rsp_ptr->qr.opcode == UPIU_QUERY_OPCODE_READ_DESC) {
> - u8 *descp = (u8 *)&lrbp->ucd_rsp_ptr +
> - GENERAL_UPIU_REQUEST_SIZE;
> + u8 *descp = (u8 *)lrbp->ucd_rsp_ptr + GENERAL_UPIU_REQUEST_SIZE;
> u16 len;
>
> /* data segment length */
> --
> 1.8.3.1
>
Acked-by: Santosh Y <santoshsy@xxxxxxxxx>
--
~Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
