One tool for breaking patches up is "git citool" highlight what you want to add to the patch and then right click and select "stage lines for commit". So for example let's go through the changes to drivers/scsi/arcmsr/arcmsr.h. These should be broken up into multiple patches with the easiest whitespace patches first. The original patch adds 520 lines of code (I'm looking at the plus marks in git show 17628f3a062b | diffstat). Out of those 392 line are pure white space changes such as tabs or indents. 9 lines are adding parenthesis around macros. 4 lines are changing int32_t to uint32_t. It's not clear if there was a signedness bug in the original code or if this is purely cosmetic. That should be mentioned in the changelog. The remaining 115 lines are related to the new feature. So this should be a series of patches. [patch 1/4] whitespace (this is the largest patch in the series). [patch 2/4] add parenthesis [patch 3/4] change signed to unsigned [patch 4/4] add feature (this would touch other the other files as well) The first 3 patches are trivial to review and then the last one is much smaller and easier to review than when everything was mixed together. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
