Hi James, Comments inline.. >On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote: >> From: Atul Deshmukh <atul.deshmukh@xxxxxxxxxx> > >You seem to have stopped running your stuff through checkpatch: <SK> We did run all the patches through checkpatch before submission, did see the warnings and was trying to keep with the formatting in the rest of the file(s). We will take care of this in future. Thanks, ~Saurav > >WARNING: please, no spaces at the start of a line >#317: FILE: drivers/scsi/qla2xxx/qla_gbl.h:479: >+ uint8_t *, uint32_t, uint32_t);$ > >WARNING: please, no spaces at the start of a line >#341: FILE: drivers/scsi/qla2xxx/qla_gbl.h:713: >+ const uint32_t crb_reg, const uint32_t value);$ > >WARNING: please, no spaces at the start of a line >#351: FILE: drivers/scsi/qla2xxx/qla_gbl.h:723: >+ uint32_t, uint32_t);$ > >WARNING: please, no spaces at the start of a line >#3175: FILE: drivers/scsi/qla2xxx/qla_nx2.c:2084: >+ struct qla8044_minidump_entry_hdr *entry_hdr)$ > >WARNING: please, no spaces at the start of a line >#4258: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3167: >+ uint32_t data)$ > >WARNING: please, no spaces at the start of a line >#4334: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3243: >+ uint32_t sector_start_addr)$ > >WARNING: please, no spaces at the start of a line >#4390: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3299: >+ uint32_t *p_data)$ > >WARNING: please, no spaces at the start of a line >#4425: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3334: >+ uint32_t faddr, uint32_t dwords)$ > >WARNING: please, no spaces at the start of a line >#4508: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3417: >+ uint32_t faddr, uint32_t dwords)$ > >WARNING: please, no spaces at the start of a line >#4528: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3437: >+ uint32_t offset, uint32_t length)$ > >total: 0 errors, 10 warnings, 5781 lines checked > >Please don't; those are all legitimate problems. > >James >
<<attachment: winmail.dat>>
