Re: [PATCH 4/5] target/qla2xxx: Define NPIV ops in terms of normal ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 20, 2013 at 06:00:06PM -0700, Andy Grover wrote:
> Instead of defining a second target_core_fabric_ops struct, use the
> same one as normal (tcm_qla2xxx_ops) and then fixup the changed methods.
> 
> This should make it a little easier to pick out the npiv differences, and
> also save a little space.
> 
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>

Can't say I'm a huge fan of either the old or new way, I'd rather have
the methods contain both the NPIV and non-NPIV code inline.  If that's
what you're preparing for I'm supportive of this, otherwise I don't
really care too much about it.  Looks correct at least..

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux