On Tue, Aug 20, 2013 at 06:00:06PM -0700, Andy Grover wrote: > Instead of defining a second target_core_fabric_ops struct, use the > same one as normal (tcm_qla2xxx_ops) and then fixup the changed methods. > > This should make it a little easier to pick out the npiv differences, and > also save a little space. > > Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> Can't say I'm a huge fan of either the old or new way, I'd rather have the methods contain both the NPIV and non-NPIV code inline. If that's what you're preparing for I'm supportive of this, otherwise I don't really care too much about it. Looks correct at least.. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html