Hi James, This patch set seem to be fine. Please consider these patches. Regards, Sreekanth. >-----Original Message----- >From: Joe Lawrence [mailto:joe.lawrence@xxxxxxxxxxx] >Sent: Friday, August 09, 2013 2:16 AM >To: linux-scsi@xxxxxxxxxxxxxxx >Cc: Reddy, Sreekanth; Joe Lawrence >Subject: [PATCH v3 0/2] mpt2sas/mpt3sas resource cleanup fixes > >Hi Sreekanth, > >Here are the patches that address your offlist feedback and testing of earlier >patchset versions. > >I tested with as many early exits as I could think of inside of >mpt2sas_base_map_resources to verify, so I believe all error paths should be >safe and message-log-friendly. > >Regards, > >Joe > >--- > >Changes from v2 (offlist): > - Clear ioc->bars if pci_enable_device_mem fails. > - pci_release_selected_regions verifies non-zero bar pointer, so as > long as it's cleared when not actually enabled, we don't need to > check it first. > >Changes from v1: > - Verify that the PCI device is enabled before disabling it. > - Verify that the PCI BARs have been enabled before releasing them. > >Joe Lawrence (2): > mpt2sas: fix cleanup on controller resource mapping failure > mpt3sas: fix cleanup on controller resource mapping failure > > drivers/scsi/mpt2sas/mpt2sas_base.c | 27 +++++++++++++++++---------- >drivers/scsi/mpt2sas/mpt2sas_scsih.c | 1 + >drivers/scsi/mpt3sas/mpt3sas_base.c | 27 +++++++++++++++++---------- >drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 + > 4 files changed, 36 insertions(+), 20 deletions(-) > >-- >1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html