RE: Incorrect LBA Returned from scsi_get_lba() and blk_rq_pos() (Possible DIF Impact)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

Did you get a chance to merge your changes into mainline?  I'm using
3.10.4 and am still seeing this issue.

Thanks,

Kamaljit


-----Original Message-----
From: linux-scsi-owner@xxxxxxxxxxxxxxx
[mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Martin K.
Petersen
Sent: Tuesday, February 12, 2013 10:09 AM
To: Sami Waheed
Cc: linux-scsi@xxxxxxxxxxxxxxx
Subject: Re: Incorrect LBA Returned from scsi_get_lba() and blk_rq_pos()
(Possible DIF Impact)

>>>>> "Sami" == Sami Waheed <Sami.Waheed@xxxxxxxx> writes:

Sami> I am testing a SCSI/SAS target with a block size of 4K.  I noticed
Sami> that scsi_get_lba which calls blk_rq_pos is returning an incorrect
Sami> LBA.  The returned LBA value is 8x the actual LBA specified in the
Sami> CDB:

The block layer always uses 512-byte sectors internally, regardless of
the logical block size of the actual disk.


Sami> I, also, noticed that several drivers use the scsi_get_lba inline
Sami> in scsi_cmnd.h to set/check ref tag for DIF.  On a 4K device, this
Sami> is resulting in an incorrect ref tag.

I have some patches in the pipeline that fixes this. They also add
support for protection intervals different from the logical block size.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux