On 08/05/13 03:20, Anton Blanchard wrote: > > Hi Randy, > > commit 6a7252fd ([SCSI] lpfc: fix up Kconfig dependencies) added a > select of GENERIC_CSUM. This seems strange to me - it's an architecture > specific detail if the checksum routines are implemented in assembly or > if they pull in lib/checksum.c. > > The networking code doesn't select GENERIC_CSUM, so I'm not sure why > the lpfc driver needs to. Was there a real issue we hit here? > > Regards, > Anton > Hi Anton, I reported: """ on i386: # CONFIG_CRC_T10DIF is not set drivers/built-in.o: In function `lpfc_bg_crc': (.text+0x3cb3c9): undefined reference to `crc_t10dif' """ and then James Bottomley provided the patch. I don't know why he added GENERIC_CSUM to it. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
