Hi Jingoo, On Wed, Aug 7, 2013 at 5:45 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: >> On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: >> >> > @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port) >> > */ >> > dprintkl(KERN_WARNING, >> > "EEProm checksum error: using default values and options.\n"); >> > - eeprom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM; >> > + eeprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & 0xff); >> >> Hi, >> >> if you are fixing these issues please use the proper macros for >> conversion of endianness. > > Then, do you mean the following? :) > > - prom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM; > + eprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & le16_to_cpu(0xff)); No. The issue is that the driver is doing things like this: eeprom->member[0] = (u8)(CONSTANT & 0xff); eeprom->member[1] = (u8)(CONSTANT >> 8); Which is exactly the same as code along the lines of: eeprom->member = cpu_to_le16(CONSTANT); Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
