On Sat, 2013-07-27 at 02:07 +0900, Akinobu Mita wrote: > 2013/7/26 Martin Peschke <mpeschke@xxxxxxxxxxxxxxxxxx>: > > On Mon, 2013-07-15 at 20:52 +0900, Akinobu Mita wrote: > >> With module parameter num_parts > 0, partition table is built on the > >> ramdisk storage when loading the driver. Unfortunately, there is an > >> endianness bug in sdebug_build_parts(). So the partition table is not > >> correctly initialized on big-endian systems. > >> > >> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > >> Cc: "James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx> > >> Cc: Douglas Gilbert <dgilbert@xxxxxxxxxxxx> > >> Cc: linux-scsi@xxxxxxxxxxxxxxx > >> --- > >> drivers/scsi/scsi_debug.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c > >> index cb4fefa..2f39b13 100644 > >> --- a/drivers/scsi/scsi_debug.c > >> +++ b/drivers/scsi/scsi_debug.c > >> @@ -2659,8 +2659,8 @@ static void __init sdebug_build_parts(unsigned char *ramp, > >> / sdebug_sectors_per; > >> pp->end_sector = (end_sec % sdebug_sectors_per) + 1; > >> > >> - pp->start_sect = start_sec; > >> - pp->nr_sects = end_sec - start_sec + 1; > >> + pp->start_sect = cpu_to_le32(start_sec); > >> + pp->nr_sects = cpu_to_le32(end_sec - start_sec + 1); > >> pp->sys_ind = 0x83; /* plain Linux partition */ > >> } > >> } > > > > > > I have posted the same fix several times, e.g. > > http://marc.info/?l=linux-scsi&m=137051617907423&w=2 > > Good luck! > > > > Acked-by: Martin Peschke <mpeschke@xxxxxxxxxxxxxxxxxx> > > Thanks. I found this problem from sparse warning noticed by 0-DAY kernel > build testing. It surfaced as a real problem on System z (big endian). That is why I can confirm that the above patch works. Thanks, Martin -- Linux on System z Development IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
