Hi Anand, On 07/25/2013 06:44 AM, Anand Kumar Santhanam wrote: > Hi Hans, > > Are you planning to address the below comment and submit an updated > patch? I think there was a misunderstanding there. It was my impression that you would do a follow-up patch for that. I can add the define if you want, but where do you want it? In pm8001_defs.h with the name PM80XX_MPI_IOMB_SIZE_SPCV? Should I create a PM8001_MPI_IOMB_SIZE_SPCV as well? Regards, Hans > > Regards > Anand > > -----Original Message----- > From: Jack Wang [mailto:xjtuwjp@xxxxxxxxx] > Sent: Monday, July 15, 2013 3:14 PM > To: Hans Verkuil > Cc: linux-scsi@xxxxxxxxxxxxxxx; Anand Kumar Santhanam; > lindar_liu@xxxxxxxxx; Sangeetha Gnanasekaran; > jinpu.wang@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH] pm80xx: fix Adaptec 71605H hang > > On 07/14/2013 10:25 AM, Hans Verkuil wrote: >> The IO command size is 128 bytes for these new controllers as opposed >> to 64 for the old 8001 controller. >> >> The Adaptec out-of-tree driver did this correctly. After comparing the > >> two this turned out to be the crucial difference. > Thanks Hans for this fix. > We'd better use more meaningful Micro like: > > #define MPI_IOMB_SIZE_SPCV 128 and replace current hard coded one. > > Thanks, > Jack >> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> Acked-by: AnandKumar.Santhanam@xxxxxxxx >> Cc: stable@xxxxxxxxxxxxxxx # for v3.10 and up >> --- >> drivers/scsi/pm8001/pm80xx_hwi.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c >> b/drivers/scsi/pm8001/pm80xx_hwi.c >> index 302514d..e1db5ca 100644 >> --- a/drivers/scsi/pm8001/pm80xx_hwi.c >> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c >> @@ -275,7 +275,7 @@ static void init_default_table_values(struct >> pm8001_hba_info *pm8001_ha) >> >> for (i = 0; i < PM8001_MAX_SPCV_INB_NUM; i++) { >> pm8001_ha->inbnd_q_tbl[i].element_pri_size_cnt = >> - PM8001_MPI_QUEUE | (64 << 16) | (0x00<<30); >> + PM8001_MPI_QUEUE | (128 << 16) | (0x00<<30); >> pm8001_ha->inbnd_q_tbl[i].upper_base_addr = >> pm8001_ha->memoryMap.region[IB + > i].phys_addr_hi; >> pm8001_ha->inbnd_q_tbl[i].lower_base_addr = >> @@ -301,7 +301,7 @@ static void init_default_table_values(struct > pm8001_hba_info *pm8001_ha) >> } >> for (i = 0; i < PM8001_MAX_SPCV_OUTB_NUM; i++) { >> pm8001_ha->outbnd_q_tbl[i].element_size_cnt = >> - PM8001_MPI_QUEUE | (64 << 16) | (0x01<<30); >> + PM8001_MPI_QUEUE | (128 << 16) | (0x01<<30); >> pm8001_ha->outbnd_q_tbl[i].upper_base_addr = >> pm8001_ha->memoryMap.region[OB + > i].phys_addr_hi; >> pm8001_ha->outbnd_q_tbl[i].lower_base_addr = >> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
