Re: [PATCHv2 0/7] Limit overall SCSI EH runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote:
> This patchset implements a new 'eh_deadline' attribute to the
> SCSI host. It will limit the overall SCSI EH runtime by a given
> timeout. If the timeout is reached all intermediate EH steps
> will be skipped and host reset will be scheduled immediately.
> 
> For this patch I've re-used the existing 'last_reset' field
> of the SCSI host to store the initial time SCSI EH started.
> Also the field 'resetting' has been removed as it never has
> been used as intended.
> 
> As 'last_reset' might be in use by transport-specific EH
> implementation I've disallowed eh_deadline setting there.
> 
> Changes from the initial version:
> - Add list_splice_init() calls to avoid stale commands
> - Rename function to scsi_host_eh_past_deadline
> 
> Hannes Reinecke (7):
>   dpt_i2o: Remove DPTI_STATE_IOCTL
>   dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset
>   advansys: Remove 'last_reset' references
>   tmscsim: Move 'last_reset' into host structure
>   dc395: Move 'last_reset' into internal host structure
>   scsi: remove check for 'resetting'
>   scsi: Add 'eh_deadline' to limit SCSI EH runtime
> 
>  drivers/scsi/advansys.c   |   8 +--
>  drivers/scsi/dc395x.c     |  24 +++++----
>  drivers/scsi/dpt_i2o.c    |  35 +++++--------
>  drivers/scsi/dpti.h       |   1 -
>  drivers/scsi/hosts.c      |   7 +++
>  drivers/scsi/scsi.c       |  28 ----------
>  drivers/scsi/scsi_error.c | 130 +++++++++++++++++++++++++++++++++++++++++++---
>  drivers/scsi/scsi_sysfs.c |  37 +++++++++++++
>  drivers/scsi/tmscsim.c    |  14 ++---
>  drivers/scsi/tmscsim.h    |   1 +
>  include/scsi/scsi_host.h  |   4 +-
>  11 files changed, 208 insertions(+), 81 deletions(-)
> 

Looks good.  We have been testing this extensively.

Acked-by: Ewan D. Milne <emilne@xxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux