On Fri, 2013-06-28 at 09:14 +0200, Hannes Reinecke wrote:
> >> @@ -232,6 +272,9 @@ int scsi_eh_scmd_add(struct scsi_cmnd *scmd, int eh_flag)
> >> if (scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY))
> >> goto out_unlock;
> >>
> >> + if (sdev->eh_deadline && !shost->last_reset)
> >> + shost->last_reset = jiffies;
> >> +
> >
> > I think this is supposed to be if (shost->eh_deadline ...
> >
> No. ->last_reset is set to the time the first command timeout/failure.
>
> ->last_reset + ->eh_deadline will give you the expiry time.
Sorry, I wasn't clear what I meant. What I meant was:
if (shost->eh_deadline && !shost->last_reset)
shost->last_reset = jiffies;
...because the eh_deadline field is in struct Scsi_Host, not
in struct scsi_device.
-Ewan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
