Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-06-28 at 09:14 +0200, Hannes Reinecke wrote:

> >> @@ -232,6 +272,9 @@ int scsi_eh_scmd_add(struct scsi_cmnd *scmd, int eh_flag)
> >>  		if (scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY))
> >>  			goto out_unlock;
> >>  
> >> +	if (sdev->eh_deadline && !shost->last_reset)
> >> +		shost->last_reset = jiffies;
> >> +
> > 
> > I think this is supposed to be if (shost->eh_deadline ...
> > 
> No. ->last_reset is set to the time the first command timeout/failure.
> 
> ->last_reset + ->eh_deadline will give you the expiry time.

Sorry, I wasn't clear what I meant.  What I meant was:

          if (shost->eh_deadline && !shost->last_reset)
                  shost->last_reset = jiffies;

...because the eh_deadline field is in struct Scsi_Host, not
in struct scsi_device.

-Ewan



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux