Thanks James for pointing this out, there is no harm with this change. Acked-by: Sumit Saxena <sumit.saxena@xxxxxxx> Sumit >-----Original Message----- >From: James Georgas [mailto:soulpa7ch@xxxxxxxxx] >Sent: Wednesday, June 26, 2013 11:33 PM >To: DL-MegaRAID Linux; JBottomley@xxxxxxxxxxxxx >Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; James >Georgas >Subject: [PATCH 1/1] scsi/megaraid: minor cut and paste error fixed. > >This looks like a cut and paste typo to me. Both of the >megasas_read_fw_status_reg_* functions involved are identical though, so >there was no bad behaviour. I changed it for consistency and clarity. > >Signed-off-by: James Georgas <soulpa7ch@xxxxxxxxx> >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index 3a9ddae..87591cd 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -583,7 +583,7 @@ megasas_clear_intr_skinny(struct >megasas_register_set __iomem *regs) > /* > * Check if it is our interrupt > */ >- if ((megasas_read_fw_status_reg_gen2(regs) & MFI_STATE_MASK) == >+ if ((megasas_read_fw_status_reg_skinny(regs) & MFI_STATE_MASK) == > MFI_STATE_FAULT) { > mfiStatus = MFI_INTR_FLAG_FIRMWARE_STATE_CHANGE; > } else >-- >1.8.1.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
