Il 09/05/2013 22:20, Matthew Wilcox ha scritto:
> NVMe: Add nvme-scsi.c
I couldn't find the original patch on LKML, so I'll just quote the
relevant piece of code.
> +int nvme_sg_io(struct nvme_ns *ns, struct sg_io_hdr __user *u_hdr)
> +{
> + struct sg_io_hdr hdr;
> + int retcode;
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EACCES;
This should be EPERM, and also it should use the same checks as other
implementations of SG_IO, including:
- checking if it's operating on a partition, and requiring CAP_SYS_RAWIO
if so;
- allowing a limited number of commands even for !capable(CAP_SYS_RAWIO).
All this is done by scsi_cmd_blk_ioctl.
Paolo
> + if (copy_from_user(&hdr, u_hdr, sizeof(hdr)))
> + return -EFAULT;
> + if (hdr.interface_id != 'S')
> + return -EINVAL;
> + if (hdr.cmd_len > BLK_MAX_CDB)
> + return -EINVAL;
> +
> + retcode = nvme_scsi_translate(ns, &hdr);
> + if (retcode < 0)
> + return retcode;
> + if (retcode > 0)
> + retcode = SNTI_TRANSLATION_SUCCESS;
> + if (copy_to_user(__user u_hdr, &hdr, sizeof(sg_io_hdr_t)) > 0)
> + return -EFAULT;
> +
> + return retcode;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
