Re: [PATCH 08/10] qla2xxx: Fix qla2xxx_check_risc_status()

[Saurav Kashyap <saurav.kashyap@xxxxxxxxxx>]

Acked-by: Saurav Kashyap <saurav.kashyap@xxxxxxxxxx>



>Change the 'rval' variable from QLA_FUNCTION_TIMEOUT into QLA_SUCCESS
>before starting a loop that is only executed if rval is initialized
>to QLA_SUCCESS. Coverity reported that loop as "dead code".
>
>Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
>Cc: Chad Dupuis <chad.dupuis@xxxxxxxxxx>
>Cc: Saurav Kashyap <saurav.kashyap@xxxxxxxxxx>
>---
> drivers/scsi/qla2xxx/qla_isr.c |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/scsi/qla2xxx/qla_isr.c
>b/drivers/scsi/qla2xxx/qla_isr.c
>index 259d920..bd0e2fa 100644
>--- a/drivers/scsi/qla2xxx/qla_isr.c
>+++ b/drivers/scsi/qla2xxx/qla_isr.c
>@@ -2495,6 +2495,7 @@ qla2xxx_check_risc_status(scsi_qla_host_t *vha)
> 	if (rval == QLA_SUCCESS)
> 		goto next_test;
> 
>+	rval = QLA_SUCCESS;
> 	WRT_REG_DWORD(&reg->iobase_window, 0x0003);
> 	for (cnt = 100; (RD_REG_DWORD(&reg->iobase_window) & BIT_0) == 0 &&
> 	    rval == QLA_SUCCESS; cnt--) {
>-- 
>1.7.10.4
>
>

<<attachment: winmail.dat>>