Re: [PATCH 8/9] mpt2sas: Enable new EH timeout handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 June 2013 09:40:57 +0200, Hannes Reinecke wrote:
> 
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> ---
>  drivers/scsi/mpt2sas/mpt2sas_scsih.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index c6bdc92..47fc66c 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -2565,6 +2565,16 @@ _scsih_tm_display_info(struct MPT2SAS_ADAPTER *ioc, struct scsi_cmnd *scmd)
>  }
>  
>  /**
> + * _scsih_timed_out - eh timeout handler
> + * @scmd: pointer to scsi command object
> + */
> +static enum blk_eh_timer_return
> +_scsih_timed_out(struct scsi_cmnd *scmd)
> +{
> +	return scsi_abort_command(scmd);
> +}

Why did you create this function and not do the following?
+	.eh_timed_out			= scsi_abort_command,

> +/**
>   * _scsih_abort - eh threads main abort routine
>   * @scmd: pointer to scsi command object
>   *
> @@ -7515,6 +7525,7 @@ static struct scsi_host_template scsih_driver_template = {
>  	.scan_start			= _scsih_scan_start,
>  	.change_queue_depth 		= _scsih_change_queue_depth,
>  	.change_queue_type		= _scsih_change_queue_type,
> +	.eh_timed_out			= _scsih_timed_out,
>  	.eh_abort_handler		= _scsih_abort,
>  	.eh_device_reset_handler	= _scsih_dev_reset,
>  	.eh_target_reset_handler	= _scsih_target_reset,
> -- 
> 1.7.12.4
> 

Jörn

--
The cheapest, fastest and most reliable components of a computer
system are those that aren't there.
-- Gordon Bell, DEC labratories
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux