Re: [PATCH 1/9] target: Add transport_cmd_check_stop write_pending bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 7 June 2013 21:34:16 +0000, Nicholas A. Bellinger wrote:
>  
> -static int transport_cmd_check_stop(struct se_cmd *cmd, bool remove_from_lists)
> +static int transport_cmd_check_stop(struct se_cmd *cmd, bool remove_from_lists,
> +				    bool write_pending)
...

> -	return transport_cmd_check_stop(cmd, true);
> +	return transport_cmd_check_stop(cmd, true, false);

At this point I would prefer to pass in a flags.
transport_cmd_check_stop(cmd, SC_REMOVE_FROM_LISTS) seems more
readable to me.

The rest of the patchset I rather like.  Well done.

Jörn

--
When you close your hand, you own nothing. When you open it up, you
own the whole world.
-- Li Mu Bai in Tiger & Dragon
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux