> -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Bart Van Assche > Sent: Monday, June 03, 2013 11:54 PM > To: Shergill, Gurinder > Cc: linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] make dev_loss_tmo checks uniform across drivers > > On 06/03/13 20:25, gurinder.shergill@xxxxxx wrote: > > The dev_loss_tmo parameter controls how long the FC transport layer > > insulates a loss of a remote port. It is defined to be between 1 and > > SCSI_DEVICE_BLOCK_MAX_TIMEOUT (600). Different drivers do slightly > > different checks when passed this parameter. This patch makes the > > dev_loss_tmo setting uniform across all the drivers by pulling the > > common logic into the transport layer function which is responsible > > for invoking the driver provided callouts. > > > > In addition, this patch also fixes a issue (see below), where > > dev_loss_tmo could end up with a value more than > > SCSI_DEVICE_BLOCK_MAX_TIMEOUT when fast_io_fail_tmo is enabled and > > then disabled. The change is to never allow dev_loss_tmo to be out of > > its defined range. And, once that is a given, then fast_io_fail_tmo can > be capped by dev_loss_tmo. > > Hello Sunny, > > As far as I know some users set fast_io_fail_tmo such that dev_loss_tmo > can be set to a very large value in order to prevent that the SCSI host > number changes. Sorry but I'm not sure it's a good idea to remove that > functionality. Fair enough. I wasn't aware of such usage of fast_io_fail_tmo. I'll take that part out of the patch. Thanks for the feedback, Sunny -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
