Re: [PATCH] scsi: replace strict_strtoul() with kstrtoul()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 1, 2013 at 10:29 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.

> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4204,7 +4204,7 @@ static ssize_t pmcraid_store_log_level(
>         struct pmcraid_instance *pinstance;
>         unsigned long val;
>
> -       if (strict_strtoul(buf, 10, &val))
> +       if (kstrtoul(buf, 10, &val))
>                 return -EINVAL;
>         /* log-level should be from 0 to 2 */
>         if (val > 2)

int ret;

ret = kstrtoul(...);
if (ret)
 return ret;

> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index 931a7d9..bf36b45 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -790,7 +790,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
>         struct scsi_device *sdev = to_scsi_device(dev);
>         unsigned long period;
>
> -       if (strict_strtoul(buf, 10, &period))
> +       if (kstrtoul(buf, 10, &period))
>                 return -EINVAL;

Ditto.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux