-----Original Message----- From: Mike Christie <michaelc@xxxxxxxxxxx> Date: Tuesday 28 May 2013 2:19 PM To: Vikas <vikas.chaudhary@xxxxxxxxxx> Cc: "jbottomley@xxxxxxxxxxxxx" <jbottomley@xxxxxxxxxxxxx>, scsi <linux-scsi@xxxxxxxxxxxxxxx>, Lalit Chandivade <lalit.chandivade@xxxxxxxxxx>, Ravi Anand <ravi.anand@xxxxxxxxxx>, Harish Zunjarrao <harish.zunjarrao@xxxxxxxxxx> Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings >Come on man, same comments as last patches like this :) Could you use >the same names that we currently use for existing params? > >Check for the inorder ones and the ones where we use en instead of >enabled for the postfix. Also check the others. If we understand correctly you are suggesting to change macro postfix from EN to ENABLED as in attached patch "iscsi_net_param-fix1.patch". But we think changing old macro postfix from ENABLED to EN is better way to fix it. It will make "iscsi_if.h" consistent for iscsi_net_param, iscsi_param and iscsi_flashnode_param macros as defined in attached patch "iscsi_net_param-fix2.patch". Let us know what you think? > >Also what is up with isns. If we support passing the addr/port/enabled >then will it work completely in fw? You do not need any driver or >userspace changes for that? For now we are just adding support to enable or disable iSNS. However we need to modify driver and userspace to support iSNS.
<<attachment: winmail.dat>>
