On Fri, 2013-05-17 at 14:18 -0600, Khalid Aziz wrote: > On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > > If you're going through the trouble to fix this CamelCase stuff > > and make it work on 64 bit, how about a little more cleanup? > > Sounds good to me. btw, for the BusLogic code: There seem to be places where addresses are cast to u32. I don't know the code at all, but that could likely cause problems with 64 bit addresses. $ git grep "(u32)" drivers/scsi/BusLogic.c drivers/scsi/BusLogic.c: ccb->dma_handle = (u32) blkp + offset; drivers/scsi/BusLogic.c: fpinfo->base_addr = (u32) adapter->io_addr; drivers/scsi/BusLogic.c: extmbox_req.base_mbox_addr = (u32) adapter->mbox_space_handle; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html