>>>>> "Ronnie" == ronnie sahlberg <ronniesahlberg@xxxxxxxxx> writes: Ronnie> * please have a look at the tests and the test results I linked Ronnie> to above. I currently have quite a few tests but am happy to Ronnie> add more. Aside from issuing commands with various bits set, I'd like to see some more sanity checking. Mainly to see whether it responds correctly to the features is claims to support. I.e. do the values reported in the Block Limits VPD look sane given what we know about the device in general (SCSI level, capacity, PI supported, discard supported, etc.)? Right now you always expect RDPROTECT/WRPROTECT > 0 to fail, but they should succeed if the device is formatted with PI. FWIW, my slightly outdated document is here: https://oss.oracle.com/~mkp/docs/linux-advanced-storage.pdf -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
