device_type is a sas_device_type, not a sas_dev_type. 1 drivers/scsi/mvsas/mv_sas.c: In function 'mvs_update_phyinfo': 2 drivers/scsi/mvsas/mv_sas.c:1162:34: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] 3 if (phy->identify.device_type == SAS_END_DEV) 4 ^ 5 drivers/scsi/mvsas/mv_sas.c:1165:39: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare] 6 else if (phy->identify.device_type != NO_DEVICE) Signed-off-by: Kyle McMartin <kyle@xxxxxxxxxx> --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/scsi/mvsas/mv_sas.c @@ -1159,10 +1159,10 @@ void mvs_update_phyinfo(struct mvs_info *mvi, int i, int get_st) phy->identify.device_type = phy->att_dev_info & PORT_DEV_TYPE_MASK; - if (phy->identify.device_type == SAS_END_DEV) + if (phy->identify.device_type == SAS_END_DEVICE) phy->identify.target_port_protocols = SAS_PROTOCOL_SSP; - else if (phy->identify.device_type != NO_DEVICE) + else if (phy->identify.device_type != SAS_PHY_UNUSED) phy->identify.target_port_protocols = SAS_PROTOCOL_SMP; if (oob_done) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
