Hi James, I have resubmitted the patchset after fixing the array out of bounds issue. Pls pull the same. I guess I did not make myself clear with my earlier mail. I compiled my earlier patchset using the Kernel Makefile and I did not get the array out of bounds warning even I had -Wall -O2 flags enabled. So I was just wondering whether you are using any special settings such that you are able to see the warning. Regards Anand -----Original Message----- From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] Sent: Friday, May 03, 2013 11:29 AM To: Anand Kumar Santhanam Cc: linux-scsi@xxxxxxxxxxxxxxx; Harry Yang; Vishwanath Maram; sakthivel.sk@xxxxxxx; Rich Bono; Sangeetha Gnanasekaran Subject: Re: [PATCH V4 2/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC On Thu, 2013-05-02 at 19:26 -0700, Anand Kumar Santhanam wrote: > James, > > Can you pls let us know the warning flags you are including in your > makefile such that we can check from our end. > Obviously it looks like we did not use -Warray-bounds in this case. Oh good grief, please stop wasting my time. You have the definition here in your patch: > + u32 rsvd1[2]; And then you use it as: > + pm8001_ha->gs_tbl.pm8001_tbl.rsvd1[0] = > + pm8001_mr32(address, 0x38); > + pm8001_ha->gs_tbl.pm8001_tbl.rsvd1[1] = > + pm8001_mr32(address, 0x3C); > + pm8001_ha->gs_tbl.pm8001_tbl.rsvd1[2] = > + pm8001_mr32(address, 0x40); That last one goes over the array bounds because an array declared as rsvdl1[2] only has two elements: 0 and 1 ... this isn't rocket science or esoteric compiler flags, this is basic C. Stop quibbling and fix it, please. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
