Re: [PATCH] tcm_fc: using kfree_rcu() to simplify the code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wei,

On Mon, 2013-03-11 at 21:48 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> The callback function of call_rcu() just calls a kfree(), so we
> can use kfree_rcu() instead of call_rcu() + callback function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---

Apologies for the delay.

Applied to target-pending/for-next.

Thanks!

--nab

>  drivers/target/tcm_fc/tfc_sess.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
> index 113f335..4859505 100644
> --- a/drivers/target/tcm_fc/tfc_sess.c
> +++ b/drivers/target/tcm_fc/tfc_sess.c
> @@ -428,19 +428,12 @@ static int ft_prli(struct fc_rport_priv *rdata, u32 spp_len,
>  	return ret;
>  }
>  
> -static void ft_sess_rcu_free(struct rcu_head *rcu)
> -{
> -	struct ft_sess *sess = container_of(rcu, struct ft_sess, rcu);
> -
> -	kfree(sess);
> -}
> -
>  static void ft_sess_free(struct kref *kref)
>  {
>  	struct ft_sess *sess = container_of(kref, struct ft_sess, kref);
>  
>  	transport_deregister_session(sess->se_sess);
> -	call_rcu(&sess->rcu, ft_sess_rcu_free);
> +	kfree_rcu(sess, rcu);
>  }
>  
>  void ft_sess_put(struct ft_sess *sess)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux