> -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Syam Sidhardhan > Sent: Sunday, February 24, 2013 3:08 PM > To: linux-scsi@xxxxxxxxxxxxxxx > Cc: syamsidhardh@xxxxxxxxx; Anil Gurumurthy; Vijay Mohan Guvva; > JBottomley@xxxxxxxxxxxxx > Subject: [PATCH] bfa: Fix possible NULL pointer dereference & magic no > > Check for (port == NULL) has to be done before accessing port. > Also fixes the magic number. > > Signed-off-by: Syam Sidhardhan <s.syam@xxxxxxxxxxx> > --- > drivers/scsi/bfa/bfa_fcs_lport.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c > index 1224d04..69cf977 100644 > --- a/drivers/scsi/bfa/bfa_fcs_lport.c > +++ b/drivers/scsi/bfa/bfa_fcs_lport.c > @@ -5615,11 +5615,13 @@ > bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port) > bfa_port_speed_t max_speed = 0; > struct bfa_port_attr_s port_attr; > bfa_port_speed_t port_speed, rport_speed; > - bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa); > + bfa_boolean_t trl_enabled; > > > if (port == NULL) > - return 0; > + return BFA_PORT_SPEED_UNKNOWN; > + > + trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa); > > fcs = port->fcs; > Thanks for the patch Shyam. Acked-by: Vijay Mohan Guvva <vmohan@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
